[docs] Add client certificates activation and rejection behavior documentation#36793
Merged
[docs] Add client certificates activation and rejection behavior documentation#36793
Conversation
Contributor
|
Make sure to mention this behaviour in docs/src/test-api/class-testoptions.md as well. |
…entation Co-authored-by: mxschmitt <17984549+mxschmitt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [docs] Client certificates add note about rejecting all the certificates
[docs] Add client certificates activation and rejection behavior documentation
Jul 25, 2025
…lass Co-authored-by: mxschmitt <17984549+mxschmitt@users.noreply.github.com>
Contributor
Author
Done! Added the client certificates behavior documentation to |
dgozman
reviewed
Jul 25, 2025
| }); | ||
| ``` | ||
|
|
||
| Client certificate authentication is only active when at least one client certificate is provided. If you want to reject all client certificates sent by the server, you need to provide a client certificate with an `origin` that does not match any of the domains you plan to visit. |
Contributor
There was a problem hiding this comment.
We do not need this one, it should inherit the text from params.md.
Contributor
Author
There was a problem hiding this comment.
You're right! Removed the duplicate text from TestOptions since it inherits from params.md through the template system. (99f705d)
…ions Co-authored-by: dgozman <9881434+dgozman@users.noreply.github.com>
dgozman
approved these changes
Jul 28, 2025
Contributor
Test results for "tests 1"3 flaky46501 passed, 804 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the client certificates documentation to clarify two important behaviors that were missing from the current docs:
clientCertificatesarrayoriginthat does not match any of the domains you plan to visitBackground
The current documentation explains the parameter structure but doesn't mention these crucial behavioral details. Users need to understand:
clientCertificatesmeans the client won't respond to certificate requests at allhttps://not-matching.com)Changes
Added a single paragraph to the client certificates documentation in
docs/src/api/params.md:The TypeScript definitions are automatically updated by the documentation build system to reflect these changes.
Validation
npm run doctests/library/client-certificates.spec.tsFixes #36791.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.