Skip to content

chore: minor cleanups after builtins rework #35809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 30, 2025

References #35683.

@dgozman dgozman requested a review from mxschmitt April 30, 2025 09:13
@dgozman dgozman force-pushed the chore-move-things branch from 3047004 to 6e09d34 Compare April 30, 2025 09:54

This comment has been minimized.

@dgozman dgozman added the CQ1 label Apr 30, 2025

This comment has been minimized.

Copy link
Contributor

Test results for "tests others"

4 failed
❌ [webview2] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @webview2-chromium-windows
❌ [webview2] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @webview2-chromium-windows
❌ [webview2] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @webview2-chromium-windows
❌ [webview2] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @webview2-chromium-windows

4 flaky ⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-macos-latest
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-ubuntu-latest
⚠️ [electron-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @electron-windows-latest
⚠️ [webview2] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @webview2-chromium-windows

21962 passed, 513 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

3 fatal errors, not part of any test
28 failed
❌ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @channel-chromium-windows-latest
❌ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-beta-macos-latest
❌ [chromium-library] › library/inspector/cli-codegen-python.spec.ts:78:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest
❌ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chrome-beta-macos-latest
❌ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @chrome-macos-latest
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest
❌ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:99:5 › should generate routeFromHAR with --save-har @chrome-macos-latest
❌ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chrome-macos-latest
❌ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @msedge-beta-macos-latest
❌ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @msedge-beta-windows-latest
❌ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @msedge-dev-macos-latest
❌ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @msedge-dev-windows-latest
❌ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @msedge-macos-latest
❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-macos-latest
❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-macos-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-ubuntu-22.04
❌ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-ubuntu-22.04
❌ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-windows-latest
❌ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @msedge-windows-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-windows-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @msedge-windows-latest
❌ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-windows-latest
❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit
❌ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge
❌ [webkit-library] › library/emulation-focus.spec.ts:104:3 › should not affect screenshots @webkit-ubuntu-24.04

155 flaky ⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:439:5 › run-server › should respect selectors @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:484:5 › run-server › should not throw on close after disconnect @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:495:5 › run-server › should saveAs videos from remote browser @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:35:3 › should not reset timeouts @channel-chromium-macos-latest
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @channel-chromium-macos-latest
⚠️ [chromium-library] › library/screenshot.spec.ts:113:14 › page screenshot › should throw if screenshot size is too large with device scale factor @channel-chromium-windows-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python.spec.ts:133:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-beta-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @chrome-beta-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chrome-beta-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers @smoke @chrome-beta-macos-latest
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chrome-beta-ubuntu-22.04
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chrome-beta-windows-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-macos-latest
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chrome-ubuntu-22.04
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup @chrome-ubuntu-22.04
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chrome-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:237:7 › cli codegen › should not target selector preview by text regexp @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › library/capabilities.spec.ts:345:3 › service worker should register in an iframe @chromium-headed-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:784:7 › cli codegen › should assert value on disabled input @chromium-headed-windows-latest
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chromium-headed-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-headed-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-macos-14-large
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-macos-14-xlarge
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chromium-tip-of-tree-macos-13
⚠️ [chromium-library] › library/chromium/tracing.spec.ts:21:3 › should output a trace @chromium-tip-of-tree-macos-13--headed
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13--headed
⚠️ [chromium-library] › library/trace-viewer.spec.ts:467:1 › should show snapshot URL @chromium-tip-of-tree-ubuntu-22.04--headed
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chromium-tip-of-tree-windows-latest--headed
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @chromium-windows-latest
⚠️ [chromium-page] › page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/title.spec.ts:35:5 › should update primary page URL when original primary closes @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:86:1 › should reset serviceworker that hangs in importScripts @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/title.spec.ts:35:5 › should update primary page URL when original primary closes @firefox-headed-windows-latest
⚠️ [firefox-library] › library/trace-viewer.spec.ts:869:1 › should highlight target elements @firefox-headed-windows-latest
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest
⚠️ [firefox-library] › library/tracing.spec.ts:478:5 › should include interrupted actions @firefox-headed-windows-latest
⚠️ [firefox-library] › library/tracing.spec.ts:571:5 › should ignore iframes in head @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:89:5 › should connectOverCDP and manage downloads in default context @msedge-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:254:3 › does launch without a port @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:291:3 › should use SOCKS proxy for websocket requests @msedge-beta-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-beta-windows-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-dev-windows-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-dev-windows-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:306:5 › launchServer › disconnected event should have browser as argument @msedge-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:412:5 › should use proxy with connectOverCDP @msedge-macos-latest
⚠️ [chromium-library] › library/har.spec.ts:179:3 › should include form params @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @msedge-macos-latest
⚠️ [chromium-page] › page/page-autowaiting-basic.spec.ts:116:3 › should work with goto following click @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04
⚠️ [chromium-library] › library/popup.spec.ts:222:3 › should not dispatch binding on a closed page @msedge-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-windows-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [chromium-page] › page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @msedge-windows-latest
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:299:5 › should detect mime type @msedge-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:25:14 › page screenshot › should run in parallel in multiple pages @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:86:14 › page screenshot › should work with device scale factor and clip @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:276:14 › element screenshot › should restore viewport after page screenshot and exception @tracing-webkit
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @tracing-webkit
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:38:5 › should upload a folder @tracing-webkit
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:508:7 › cli codegen › should check @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:784:7 › cli codegen › should assert value on disabled input @webkit-headed-windows-latest
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:259:5 › post data › should amend utf8 post data @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-large
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened @smoke @webkit-macos-15-large
⚠️ [webkit-page] › page/page-screenshot.spec.ts:451:7 › page screenshot › mask option › should work @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/screenshot.spec.ts:25:14 › page screenshot › should run in parallel in multiple pages @webkit-ubuntu-24.04
⚠️ [webkit-library] › library/emulation-focus.spec.ts:104:3 › should not affect screenshots @webkit-windows-latest
⚠️ [webkit-page] › page/locator-misc-2.spec.ts:112:3 › should return bounding box @webkit-windows-latest

246509 passed, 9541 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman force-pushed the chore-move-things branch from 6e09d34 to 621dc57 Compare April 30, 2025 11:21
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39109 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants