Skip to content

chore(html): normalize header between views #35804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Apr 29, 2025

Normalize how headers are displayed between the test list and on test cases/results. Contains the fix of #35781 (fixes #35699).

Additionally fixes some color and padding issues.


I am not happy with the spacing with the row immediately below the title (metadata dropdown, if available, or the test file and execution time), but it is consistent and unchanged.

Screenshot 2025-04-29 at 12 51 17 PM Screenshot 2025-04-29 at 12 46 32 PM Screenshot 2025-04-29 at 12 46 36 PM Screenshot 2025-04-29 at 12 48 07 PM Screenshot 2025-04-29 at 12 48 31 PM

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:25:14 › page screenshot › should run in parallel in multiple pages @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:95:14 › page screenshot › should work with device scale factor and scale:css @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39107 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: UI Glitch: 'Next' and 'Previous' Icons Overlapping with Test Name When Name Length is Long
2 participants