chore(error context): page snapshot should contain all frames #35795
+67
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
commented
Apr 29, 2025
| if (monotonicTime() > deadline) | ||
| return; | ||
|
|
||
| const snapshotString = await raceAgainstDeadline(() => frame.locator('body').ariaSnapshot({ ref: true, timeout: 5000 }), deadline); |
There was a problem hiding this comment.
I'd like to test the failure case here, but i'm unsure how to construct a frame that takes long to snapshot. Also couldn't find any existing tests around that. @dgozman how would you test this?
Test results for "tests 1"1 failed 7 flaky39099 passed, 809 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.