Skip to content

fix(registry): create unique browser download path #35673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(registry): create unique browser download path #35673

wants to merge 1 commit into from

Conversation

gotlougit
Copy link

This allows concurrent downloads of browsers by
Playwright.

Fixes #32179

@gotlougit gotlougit force-pushed the unique-download-path branch from 6b17776 to b279325 Compare April 19, 2025 12:27
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@gotlougit gotlougit force-pushed the unique-download-path branch from b279325 to 8d3feaa Compare April 22, 2025 13:19
@gotlougit
fix(registry): create unique browser download path
8225573 
This allows concurrent downloads of browsers by
Playwright.

Fixes microsoft#32179
@gotlougit gotlougit force-pushed the unique-download-path branch from 8d3feaa to 8225573 Compare April 22, 2025 13:30
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

6 failed
❌ [installation tests] › playwright-cdn.spec.ts:133:5 › npx playwright install should not hang when CDN closes the connection @package-installations-macos-latest
❌ [installation tests] › playwright-cdn.spec.ts:160:5 › npx playwright install should not hang when CDN TCP connection stalls @package-installations-macos-latest
❌ [installation tests] › playwright-cdn.spec.ts:133:5 › npx playwright install should not hang when CDN closes the connection @package-installations-ubuntu-latest
❌ [installation tests] › playwright-cdn.spec.ts:160:5 › npx playwright install should not hang when CDN TCP connection stalls @package-installations-ubuntu-latest
❌ [installation tests] › playwright-cdn.spec.ts:133:5 › npx playwright install should not hang when CDN closes the connection @package-installations-windows-latest
❌ [installation tests] › playwright-cdn.spec.ts:160:5 › npx playwright install should not hang when CDN TCP connection stalls @package-installations-windows-latest

2 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:157:5 › mobile viewport › mouse should work with mobile viewports and cross process navigations @webkit-ubuntu-22.04-node18

39043 passed, 799 skipped
✔️✔️✔️

Merge workflow run.

dgozman
dgozman reviewed Apr 28, 2025
View reviewed changes
packages/playwright-core/src/server/registry/browserFetcher.ts
await fs.promises.unlink(zipPath);
await fs.promises.rmdir(downloadFolder, { recursive: true });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this next to the line 70, to nicely cleanup even on failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman left review comments

@dgozman dgozman dgozman left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gotlougit @pavelfeldman @dgozman