Skip to content

feat: Add maxRedirects to options of apiRequest.newContext#35160

Merged
dgozman merged 1 commit intomicrosoft:mainfrom
cpAdm:max-redirects-new-context-option
Mar 17, 2025
Merged

feat: Add maxRedirects to options of apiRequest.newContext#35160
dgozman merged 1 commit intomicrosoft:mainfrom
cpAdm:max-redirects-new-context-option

Conversation

@cpAdm
Copy link
Contributor

@cpAdm cpAdm commented Mar 12, 2025

Add maxRedirects to options parameter of apiRequest.newContext

Closes: #35127

@cpAdm
Copy link
Contributor Author

cpAdm commented Mar 12, 2025

@microsoft-github-policy-service agree

@github-actions
Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @ubuntu-22.04-chromium-tip-of-tree
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

38728 passed, 807 skipped
✔️✔️✔️

Merge workflow run.

@cpAdm
Copy link
Contributor Author

cpAdm commented Mar 12, 2025

The failing check seems to also occur in other PR's, so I don't think I should solve it?

@mxschmitt mxschmitt requested a review from yury-s March 13, 2025 09:56
@dgozman
Copy link
Contributor

dgozman commented Mar 17, 2025

Thank you for the PR, looks great!

The failing check seems to also occur in other PR's, so I don't think I should solve it?

Yes, that check is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add maxRedirects to options of apiRequest.newContext

2 participants