Skip to content

chore: improve prompt to use code frame and inline error#35032

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:better_prompt
Mar 5, 2025
Merged

chore: improve prompt to use code frame and inline error#35032
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:better_prompt

Conversation

@pavelfeldman
Copy link
Member

}
}

async function loadSource(file: string, sourceCache: Map<string, string>) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is at most one failing test before we kill the worker anyway.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Test results for "tests 1"

1 failed
❌ [default-reuse] › tests/run-tests.spec.ts:340:5 › should only create test run if file belongs to context @vscode-extension

5 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node18-1
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [chromium] › tests/headerView.spec.tsx:43:1 › should toggle filters @web-components-html-reporter
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

38643 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants