Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Prevent workflows from automatically running on forks #34408

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Jan 21, 2025

Our CI workflows are set to automatically trigger on certain conditions. These conditions currently hold even if we're operating on a fork. This means that a user with a fork making a change/branch that meets the workflow rules will end up running the CI against their personal account, which can have cost consequences.

Prevent the jobs from running on any repo besides microsoft/playwright.

Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node20-1

33725 passed, 534 skipped
✔️✔️✔️

Merge workflow run.

@agg23 agg23 merged commit b75fc4c into microsoft:main Jan 22, 2025
28 of 31 checks passed
mxschmitt added a commit to mxschmitt/playwright that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants