Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove --save-trace codegen option #34362

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

pavelfeldman
Copy link
Member

No description provided.

@pavelfeldman pavelfeldman force-pushed the remove_codegen_save_trace branch from f080cfb to 6c03b8f Compare January 16, 2025 22:57

This comment has been minimized.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep it for now. There is no better alternative for the scenario that the option was introduced for.

Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:26:5 › should print the correct imports and context options @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:795:7 › cli codegen › should middle click @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:238:3 › should use socks proxy in second page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:366:1 › should filter network requests by resource type @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/tracing.spec.ts:506:5 › should work with multiple chunks @webkit-ubuntu-22.04-node18

37596 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

@aswathpp97
Copy link

Hi, why is this --save-trace option removed from the latest version, and what is the alternative to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants