Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dotnet): improve trace viewer #30716

Merged
merged 4 commits into from
May 9, 2024

Conversation

debs-obrien
Copy link
Collaborator

No description provided.

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan that we repeat ourselves, maybe we can move it from the intro into the trace-viewer.md? And reference into it? Since it's advanced and shouldn't be in the intro imo.

@debs-obrien debs-obrien requested a review from mxschmitt May 9, 2024 08:54
@mxschmitt mxschmitt changed the title docs: improve trace viewer docs(dotnet): improve trace viewer May 9, 2024
## Opening the trace

You can open the saved trace using the Playwright CLI or in your browser on [`trace.playwright.dev`](https://trace.playwright.dev). Make sure to add the full path to where your `trace.zip` file is located. This should include the full path to your `trace.zip` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this sentence?

@debs-obrien debs-obrien merged commit 10da080 into microsoft:main May 9, 2024
3 checks passed
@debs-obrien debs-obrien deleted the trace-viewer-dotnet branch May 9, 2024 18:34
thebigbrain pushed a commit to thebigbrain/playwright that referenced this pull request May 12, 2024
mxschmitt pushed a commit to mxschmitt/playwright that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants