fix(reporters): properly determine flaky status for serial mode #30529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
test-outcome-serial-mode-fix
branch
from
0fac21f
to
6dffb48
Compare
pavelfeldman
approved these changes
Apr 25, 2024
There are plenty of edge cases in this area: - interrupted test run; - did not run because of serial mode failure; - failed before `test.skip()` call (e.g. in `beforeEach`) in one of the retries; - and more...
dgozman
force-pushed
the
test-outcome-serial-mode-fix
branch
from
6dffb48
to
c03cbb1
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 flaky27490 passed, 676 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are plenty of edge cases in this area:
test.skip()call (e.g. inbeforeEach) in one of the retries;Related issues: #28322, #28321, #27455, #17652.
Prior changes: #27762, #26385, #28360, probably more.
There is still some duplication between
outcome()and similar logic inbase.ts, which might be deduped in a follow-up.Fixes #28322.