Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HEAD): revert GET->HEAD migration, net-effect was negative #29738

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix(HEAD): revert GET->HEAD migration, net-effect was negative #29738

merged 1 commit into from
Feb 29, 2024

Conversation

pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Feb 29, 2024 •
edited
Loading

Fixes: #29732

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

10 flaky ⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all
⚠️ [webkit] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke

26633 passed, 614 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit d9a0034 into microsoft:main Feb 29, 2024
30 checks passed
pavelfeldman added a commit that referenced this pull request Feb 29, 2024
@pavelfeldman
cherry-pick(#29738): fix(HEAD): revert GET->HEAD migration, net-effec…
3f6b641 
…t was negative
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression]: HEAD requests to webServer.url since v1.42.0
2 participants
@pavelfeldman @dgozman