Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse report.jsonl without creating large string #28366

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: parse report.jsonl without creating large string #28366

merged 2 commits into from
Nov 28, 2023

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Nov 28, 2023

Reference #28362

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › test-step.spec.ts:1095:5 › should show final toPass error

2 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks

26164 passed, 612 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit 2e762fd into microsoft:main Nov 28, 2023
29 of 30 checks passed
@yury-s yury-s deleted the merge-reporter-parse-jsonl branch November 28, 2023 16:47
yury-s added a commit to yury-s/playwright that referenced this pull request Nov 28, 2023
@yury-s
cherry-pick(microsoft#28366): fix: parse report.jsonl without creatin…
ab5a716 
…g large string

Reference microsoft#28362
yury-s added a commit that referenced this pull request Nov 28, 2023
@yury-s
cherry-pick(#28366): fix: parse report.jsonl without creating large s… (
efc7ec1 
#28378)

…tring

Fixes #28362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt left review comments

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yury-s @dgozman @mxschmitt