Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(har): handle invalid Expires/Max-Age #27098

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix(har): handle invalid Expires/Max-Age #27098

merged 1 commit into from
Sep 15, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 14, 2023

Fixes #27073.

@github-actions
Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › library/proxy.spec.ts:179:3 › should exclude patterns
⚠️ [chromium] › components/splitView.spec.tsx:45:5 › should render horizontal split
⚠️ [chromium] › components/splitView.spec.tsx:65:5 › drag resize
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

25655 passed, 606 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit b3edf8e into microsoft:main Sep 15, 2023
28 checks passed
dgozman added a commit to dgozman/playwright that referenced this pull request Sep 15, 2023
@dgozman
cherry-pick(microsoft#27098): fix(har): handle invalid Expires/Max-Age
4e32d64 
Fixes microsoft#27073.
dgozman added a commit that referenced this pull request Sep 15, 2023
@dgozman
cherry-pick(#27098): fix(har): handle invalid Expires/Max-Age (#27123)
ed919f3 
Fixes #27073.
@yury-s yury-s mentioned this pull request Sep 26, 2023
Closed
1 task
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@dgozman @Germandrummer92
fix(har): handle invalid Expires/Max-Age (microsoft#27098)
9d67d07 
Fixes microsoft#27073.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] RangeError: Invalid time value
2 participants
@dgozman @pavelfeldman