fix(webkit): update Docker file to include gstreamer #2636
Conversation
|
Does the github action need an update? https://github.com/microsoft/playwright-github-action/blob/master/index.js |
test/capabilities.spec.js
Outdated
| @@ -47,7 +47,7 @@ describe('Capabilities', function() { | |||
| await page.goto(server.EMPTY_PAGE); | |||
| expect(await page.evaluate(() => window.testStatus)).toBe('SUCCESS'); | |||
| }); | |||
| it.fail(WEBKIT)('should play video', async({page, server}) => { | |||
| it.fail(WEBKIT && !LINUX)('should play video', async({page, server}) => { | |||
There was a problem hiding this comment.
wait, we don't play video on mac / win?
There was a problem hiding this comment.
According to Dmitry on mac there is a problem with our test server which doesn't support range query, so we should fix that. I will check if it works on windows and enable there separately.
There was a problem hiding this comment.
Reverting the test change for now, will enable it along with the roll.
Yep! we should theoretically see our tests failing until we update the github action as well |
I believe so, we'll probably need to bump its version too |
This adds a new script to calculate docker image size with all parent layers. Note: take this metrics with a grain of salt, since in reality docker compresses and reuses layers. Some historic stats obtained with this script: - **`208MB`** (-33MB) chore(docker): skip "recommended" dependencies (#2917) (1cebf87) - **`241MB`** (-29MB) chore(docker): trim some of the gstreamer dependencies (#2897) (bce4b1a) - **`272MB`** (-1MB) devops: do cache busting for APT (#2656) (bb34418) - **`273MB`** (+49MB) fix(webkit): update Docker file to include gstreamer (#2636) (5c6c659) - **`224MB`** (+0MB) chore: fix emojis for CR and FF in Dockerfile (#2522) (24316ad) - **`224MB`** (-1MB) fix: Dockerfile for Firefox (#1937) (b516ac4) - **`225MB`** (+49MB) devops(docker): Install ffmpeg dependency, adding codecs necessary for video playback in Firefox (#1627) (222d01c) - **`176MB`** (+32MB) chore(docs): optionally install XVFB in docker(ec3ee66) - **`144MB`** (+144MB) feat: add a playwright-ready docker image (#1161)(1781ae7)
#2449