Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selector visible and hidden #2203

Closed
wants to merge 10 commits into from
Closed

Fix selector visible and hidden #2203

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f3c3fcf
fix(waitForSelector): waiting for visible or hidden fail with multipl…
zeevrosental May 11, 2020
34f225c
waitFor example
May 12, 2020
74857ef
adding tests
May 12, 2020
d6000d8
add example waitforselector
May 12, 2020
90b76f2
delete testbank
yael118 May 12, 2020
8108fdf
Update waittask.spec.js
yael118 May 12, 2020
b7bb710
Update waittask.spec.js
yael118 May 12, 2020
301de3a
Update waittask.spec.js
yael118 May 12, 2020
d6f831a
fix(waitForSelector): waiting for visible or hidden fail with multipl…
zeevrosental May 12, 2020
776e9d3
fix(waitForSelector): waiting for visible or hidden fail with multipl…
zeevrosental May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update waittask.spec.js
  • Loading branch information
@yael118
yael118 committed May 12, 2020
commit 301de3afdf6aecc45d1b9adb833da1e4191d6c50
7 changes: 7 additions & 0 deletions test/waittask.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,13 @@ describe('Frame.waitForSelector', function() {
const waitForSelector = page.waitForSelector('div');
expect(await page.evaluate(x => x.textContent, await waitForSelector)).toBe("hi! I'm visible");
});
it('should find hidden selector when there is another element visible', async({page, server}) => {
let divFound=false
await page.setContent(`<div>content</div><div hidden="hidden">content</div>`);
const waitForSelector = page.waitForSelector('div',{state:"hidden"}).then(divFound=true);
await waitForSelector;
expect(divFound).toBe(true);
});

it('should wait for visible', async({page, server}) => {
let divFound = false;
Expand Down