feat(chromium): roll to r763809

README.md

@@ -1,14 +1,14 @@
 # 🎭 Playwright 
 
-[![npm version](https://img.shields.io/npm/v/playwright.svg?style=flat)](https://www.npmjs.com/package/playwright) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://join.slack.com/t/playwright/shared_invite/enQtOTEyMTUxMzgxMjIwLThjMDUxZmIyNTRiMTJjNjIyMzdmZDA3MTQxZWUwZTFjZjQwNGYxZGM5MzRmNzZlMWI5ZWUyOTkzMjE5Njg1NDg) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-84.0.4122.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-76.0b5-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> [![WebKit version](https://img.shields.io/badge/webkit-13.0.4-blue.svg?logo=safari)](https://webkit.org/)
+[![npm version](https://img.shields.io/npm/v/playwright.svg?style=flat)](https://www.npmjs.com/package/playwright) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://join.slack.com/t/playwright/shared_invite/enQtOTEyMTUxMzgxMjIwLThjMDUxZmIyNTRiMTJjNjIyMzdmZDA3MTQxZWUwZTFjZjQwNGYxZGM5MzRmNzZlMWI5ZWUyOTkzMjE5Njg1NDg) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-84.0.4131.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-76.0b5-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> [![WebKit version](https://img.shields.io/badge/webkit-13.0.4-blue.svg?logo=safari)](https://webkit.org/)
 
 ##### [Docs](docs/README.md) | [API reference](docs/api.md) | [Changelog](https://github.com/microsoft/playwright/releases)
 
 Playwright is a Node library to automate [Chromium](https://www.chromium.org/Home), [Firefox](https://www.mozilla.org/en-US/firefox/new/) and [WebKit](https://webkit.org/) with a single API. Playwright is built to enable cross-browser web automation that is **ever-green**, **capable**, **reliable** and **fast**.
 
 |          | Linux | macOS | Windows |
 |   :---   | :---: | :---: | :---:   |
-| Chromium <!-- GEN:chromium-version -->84.0.4122.0<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
+| Chromium <!-- GEN:chromium-version -->84.0.4131.0<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 | WebKit 13.0.4 | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 | Firefox <!-- GEN:firefox-version -->76.0b5<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 

browsers.json

@@ -2,7 +2,7 @@
   "browsers": [
     {
       "name": "chromium",
-      "revision": "760827"
+      "revision": "763809"
     },
     {
       "name": "firefox",

install-from-github.js

@@ -73,7 +73,7 @@ async function downloadAllBrowsersAndGenerateProtocolTypes() {
   }
 
   // Cleanup stale revisions.
-  const directories = new Set(await readdirAsync(path.join(__dirname, '.local-browsers')));
+  const directories = new Set(await readdirAsync(browserPaths.browsersPath(__dirname)));
   for (const browser of browsers)
     directories.delete(browserPaths.browserDirectory(__dirname, browser));
   await Promise.all([...directories].map(directory => rmAsync(directory)));

packages/playwright-chromium/browsers.json

@@ -2,7 +2,7 @@
   "browsers": [
     {
       "name": "chromium",
-      "revision": "760827"
+      "revision": "763809"
     }
   ]
 }

packages/playwright/browsers.json

@@ -2,7 +2,7 @@
   "browsers": [
     {
       "name": "chromium",
-      "revision": "760827"
+      "revision": "763809"
     },
     {
       "name": "firefox",

src/install/browserPaths.ts

@@ -75,7 +75,7 @@ function getRelativeExecutablePath(browserName: BrowserName): string[] | undefin
   }
 }
 
-function browsersPath(packagePath: string): string {
+export function browsersPath(packagePath: string): string {
   const result = getFromENV('PLAYWRIGHT_BROWSERS_PATH');
   return result || path.join(packagePath, '.local-browsers');
 }

test/headful.spec.js

@@ -57,7 +57,7 @@ describe('Headful', function() {
     await browserContext.close();
     await removeUserDataDir(userDataDir);
   });
-  it.fail(CHROMIUM)('should not crash when creating second context', async ({browserType, defaultBrowserOptions, server}) => {
+  it('should not crash when creating second context', async ({browserType, defaultBrowserOptions, server}) => {
     const browser = await browserType.launch({...defaultBrowserOptions, headless: false });
     {
       const browserContext = await browser.newContext();
@@ -71,7 +71,7 @@ describe('Headful', function() {
     }
     await browser.close();
   });
-  it.fail(CHROMIUM)('should click background tab', async({browserType, defaultBrowserOptions, server}) => {
+  it('should click background tab', async({browserType, defaultBrowserOptions, server}) => {
     const browser = await browserType.launch({...defaultBrowserOptions, headless: false });
     const page = await browser.newPage();
     await page.setContent(`<button>Hello</button><a target=_blank href="${server.EMPTY_PAGE}">empty.html</a>`);