Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(downloads): add a test for Blob downloads (#1936) #1939

Merged
merged 3 commits into from
Apr 23, 2020
Merged

tests(downloads): add a test for Blob downloads (#1936) #1939

merged 3 commits into from
Apr 23, 2020

Commits on Apr 23, 2020

  1. Add tests for Blob downloads (microsoft#1936) 

    This patch adds test cases for Blob downloads which appear to have
differing behavior on the different browsers.

NB: For each of the browsers, I manually tried going to a page that
looked like the newly added test asset page (`download-blob.html`)
and performing the steps that the test does. In each of the cases
I ended up with the target file; however, Firefox and Safari both had an
additional prompt. (I'm not sure if that prompt was a default prompt
that should be disabled when running via Playwright or if additional
handling logic is needed.)

For Chrome, this test passes (and manual replication yields a file
download).

For Firefox, this test crashes the browser (but manual replication
yields a file but requires dealing with one extra download prompt in
Firefox).

For Webkit, this test will timeout (but manual replication yields a file
but requires dealing with one extra download prompt in Webkit.)

Test Output:

```
Failures:
1) [CRASHED] Firefox Download should report download path within page.on('download', …) handler for Blobs (download.spec.js:86:3)

2) [TIMEOUT 10000ms] WebKit Download should report download path within page.on('download', …) handler for Blobs (download.spec.js:86:3)
```
    @rwoll
    rwoll committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    6459ff2 View commit details
    Browse the repository at this point in the history

  2. nit: remove PathPath -> Path

    @rwoll
    rwoll committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    2485022 View commit details
    Browse the repository at this point in the history

  3. tests: mark known downlad failures

    @rwoll
    rwoll committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    62e3efd View commit details
    Browse the repository at this point in the history