chore(chromium): resize browser frame when emulating viewport #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Apr 23, 2020
src/chromium/crPage.ts
Outdated
| @@ -67,7 +68,7 @@ export class CRPage implements PageDelegate { | |||
| this._mainFrameSession = new FrameSession(this, client, targetId); | |||
| this._sessions.set(targetId, this._mainFrameSession); | |||
| client.once(CRSessionEvents.Disconnected, () => this._page._didDisconnect()); | |||
| this._pagePromise = this._mainFrameSession._initialize().then(() => this._initializedPage = this._page).catch(e => e); | |||
| this._pagePromise = this._mainFrameSession._initialize(!!isHeadful).then(() => this._initializedPage = this._page).catch(e => e); | |||
There was a problem hiding this comment.
nit: isHeadful is always defined, make it non-optional
src/chromium/crPage.ts
Outdated
| @@ -364,10 +366,14 @@ class FrameSession { | |||
| ]; | |||
| } | |||
|
|
|||
| async _initialize() { | |||
| async _initialize(isHeadful: boolean) { | |||
There was a problem hiding this comment.
nit: can you give the parameter a name that would make more sense for headful oopif or pass actual isHeadful value in addFrameSession? It took me some time to figure out that it's not a bug in addFrameSession.
pavelfeldman
force-pushed
the
debug_mode
branch
from
a39adc8
to
f7b36fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.