Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): export selected types #1881

Merged
merged 1 commit into from
Apr 21, 2020
Merged

fix(types): export selected types #1881

merged 1 commit into from
Apr 21, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 20, 2020 •
edited
Loading

Currently exports LaunchOptions, BrowserContextOptions, Cookie and their deps.

Fixes #1732.

@JoelEinbinder
Copy link
Contributor

I don't think we need infra. Just do

export const LaunchOptions = BrowserLaunchOptions;

in overrides.d.ts

@dgozman
Copy link
Contributor Author

dgozman commented Apr 20, 2020

I don't think we need infra. Just do

export const LaunchOptions = BrowserLaunchOptions;

in overrides.d.ts

I want LaunchOptions reference Geolocation, and not BrowserLaunchOptionsGeolocation.

@dgozman
fix(types): export selected types
771655d 
Currently exports LaunchOptions, BrowserContextOptions, Cookie and their deps.
@dgozman dgozman merged commit 948d51d into microsoft:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

@JoelEinbinder JoelEinbinder Awaiting requested review from JoelEinbinder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REGRESSION]: Types for BrowserTypeLaunchOptions and BrowserContextCookies are not exported
3 participants
@dgozman @JoelEinbinder @pavelfeldman