chore: download android driver from the cdn #18466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Oct 31, 2022
| for (const file of ['android-driver.apk', 'android-driver-target.apk']) { | ||
| const fullName = path.join(executable.directory!, file); | ||
| if (!fs.existsSync(fullName)) | ||
| throw new Error('Please install Android driver apk using `npx playwright install android`'); |
There was a problem hiding this comment.
Suggested change
| throw new Error('Please install Android driver apk using `npx playwright install android`'); | |
| throw new Error('Please install Android driver apk using `${buildPlaywrightCLICommand(sdkLanguage, 'install android')}`'); |
There was a problem hiding this comment.
I don't think your suggestion compiles.
| @@ -743,7 +761,8 @@ export class Registry { | |||
| } | |||
|
|
|||
| private _downloadURLs(descriptor: BrowsersJSONDescriptor): string[] { | |||
| const downloadPathTemplate: string|undefined = (DOWNLOAD_PATHS as any)[descriptor.name][hostPlatform]; | |||
| const paths = (DOWNLOAD_PATHS as any)[descriptor.name]; | |||
| const downloadPathTemplate: string|undefined = paths[hostPlatform] || paths['<unknown>']; | |||
There was a problem hiding this comment.
I think this has a side-effect when downloading browsers, probably for unknown linux versions?
pavelfeldman
force-pushed
the
android_cdn
branch
2 times, most recently
from
d37b7d0 to
1cc49af
Compare
mxschmitt
approved these changes
Oct 31, 2022
tests/android/playwright.config.ts
Outdated
| @@ -67,6 +67,7 @@ config.projects.push({ | |||
| browserName: 'chromium', | |||
| }, | |||
| testDir: path.join(testDir, 'page'), | |||
| testMatch: /page-check/, | |||
pavelfeldman
force-pushed
the
android_cdn
branch
from
1cc49af to
3af3585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.