api(waitUntil): remove waitUntil options from the actions #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Apr 16, 2020
test/autowaiting.spec.js
Outdated
| @@ -32,7 +32,7 @@ describe('Auto waiting', () => { | |||
| page.click('a').then(() => messages.push('click')), | |||
| page.waitForNavigation({ waitUntil: 'domcontentloaded' }).then(() => messages.push('domcontentloaded')), | |||
| ]); | |||
| expect(messages.join('|')).toBe('route|domcontentloaded|click'); | |||
| expect(messages.join('|')).toBe('route|click|domcontentloaded'); | |||
There was a problem hiding this comment.
Let's change these tests to log 'commit' using the 'framenavigated' event. In the current form they are not testing anything.
yury-s
approved these changes
Apr 16, 2020
pavelfeldman
force-pushed
the
strip_wait
branch
from
6cd0f00
to
e304330
Compare
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Apr 17, 2020
…crosoft#1834)" This reverts commit d0b8710. Reason: multiple test failures on all Linux bots - https://app.circleci.com/pipelines/github/microsoft/playwright/613/workflows/50dc6e2d-23b0-41d2-9765-42983b0ed91d/jobs/610 - https://travis-ci.com/github/microsoft/playwright/builds/160648417 - https://github.com/microsoft/playwright/pull/1839/checks?check_run_id=594015893
aslushnikov
added a commit
that referenced
this pull request
Apr 17, 2020
)" (#1840) This reverts commit d0b8710. Reason: multiple test failures on all Linux bots - https://app.circleci.com/pipelines/github/microsoft/playwright/613/workflows/50dc6e2d-23b0-41d2-9765-42983b0ed91d/jobs/610 - https://travis-ci.com/github/microsoft/playwright/builds/160648417 - https://github.com/microsoft/playwright/pull/1839/checks?check_run_id=594015893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.