Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(selectors): attribute selectors pierce open shadow roots #1656

Merged
merged 1 commit into from
Apr 4, 2020
Merged

feat(selectors): attribute selectors pierce open shadow roots #1656

merged 1 commit into from
Apr 4, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 3, 2020

References #1375.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that this is not going to help with the list if I'm reaching for an element in the shadow.

@dgozman dgozman merged commit a91304a into microsoft:master Apr 4, 2020
@thernstig
Copy link
Contributor

thernstig commented Apr 4, 2020

@dgozman @pavelfeldman Shouldn't the selector name be amended/updated with regards updated name attribute? E.g.:

const handle = await page.$('attribute=some-attribute');

@dgozman
Copy link
Contributor Author

dgozman commented Apr 6, 2020

@dgozman @pavelfeldman Shouldn't the selector name be amended/updated with regards updated name attribute? E.g.:

const handle = await page.$('attribute=some-attribute');

The name did not change, we still expose some predefined selectors like id=foo. They are just implemented as attribute selectors.

@thernstig
Copy link
Contributor

Understand, maybe it is a separate issue. I just think it is confusing to call it id when it selects attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants