Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic d.ts file #161

Merged
merged 2 commits into from
Dec 6, 2019
Merged

feat: basic d.ts file #161

merged 2 commits into from
Dec 6, 2019

Conversation

JoelEinbinder
Copy link
Contributor

protocol.d.ts had to move to protocol.ts otherwise typescript refuses to include it in the out directory.

Removed the old d.ts generator. It will need to be rewritten anyway.

These new types include private stuff that they probably shouldn't, and are missing documentation. I'll follow up with a better d.ts generator later.

#6

@@ -0,0 +1,7 @@
import * as chromium from './chromium';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing copyright.

@JoelEinbinder JoelEinbinder merged commit 57313e3 into microsoft:master Dec 6, 2019
@JoelEinbinder JoelEinbinder deleted the basic_dts branch December 6, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants