fix(types): don't export derived types - #1598
Merged
Joel Einbinder (JoelEinbinder) merged 2 commits intoMar 31, 2020
Merged
Conversation
Dmitry Gozman (dgozman)
approved these changes
Mar 31, 2020
Debbie O'Brien (debs-obrien)
pushed a commit
to debs-obrien/playwright
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was playing around today with different ways of changing the way we export types for #1439. I looked at only exporting 'Parameter' types, only exporting 'Return' types, only exporting a manual list of 'important' types. They all had different pros and cons, and it was very difficult to settle on a good answer.
For now, let's not export any parameter/return types. We can whitelist some types upon user request. I'm thinking
LaunchOptionsandAccessibilitySnapshotcould be quite useful. We can always add new types after 1.0, but we can't remove them.The patch looks funny because this was my original intent for the types, but I didn't know I had to
export {}to tell typescript that my .d.ts shouldn't export everything.