Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch websocket error events #1595

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix: catch websocket error events #1595

merged 1 commit into from
Mar 31, 2020

Commits on Mar 30, 2020

  1. fix: catch websocket error events 

    WebSockets can throw an error event that has to be captured in
node to prevent application crashing.

This seems to be crashing WebKit Linux on some of the bots with the
`ECONNRESET` error:
- https://github.com/microsoft/playwright/runs/544357239

WS-related `ECONNRESET` error discussion:
- websockets/ws#1256
    @aslushnikov
    aslushnikov committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    db5ce68 View commit details
    Browse the repository at this point in the history