[Feature] waitFor() with string for selectorOrFunctionOrTimeout - return of JSHandle or ElementHandle

[thernstig]

https://github.com/microsoft/playwright/blob/master/docs/api.md#pagewaitforselectororfunctionortimeout-options-arg says it returns a JSHandle, but in case of the argument selectorOrFunctionOrTimeout being a string, the function is a shortcut for waitForSelector, which returns an ElementHandle.

Is there any way to improve in this area in regards to docs/code completion (such as VS Code IntelliSense)? Or is waitFor actually always returning a JSHandle even though selectorOrFunctionOrTimeout is a string?

If it always returns a JSHandle, is it recommended to actually use waitForSelector instead?

(Maybe the function should be removed completely and a new waitForTimeout would be better?)

[thernstig]

@pavelfeldman Great to see a change here. A question: Should waitForSelector() be deprecated instead and waitFor() be the same as waitForSelector() was?

I understand this is less than ideal with the actual name. But the reason I ask is that waitFor() is shorter and I've noticed that often using waitForSelector() wraps on a new line for the input (the selector) as it becomes longer (and if you use code formatters that only allow 80 chars width it is quite common it wraps).

A minor thing maybe, but still wanted to ask.

[thernstig]

@pavelfeldman Just wanted to see if you had any input on my last comment here. I'm not sure myself if a change is good, but good to get your reasoning around this as you are the expert.