feat(webkit): simulate device orientation events (#1852)

microsoft · Apr 20, 2020 · fb45c75 · fb45c75
1 parent 93c9083
commit fb45c75
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
   "playwright": {
     "chromium_revision": "759546",
     "firefox_revision": "1084",
-    "webkit_revision": "1197"
+    "webkit_revision": "1200"
   },
   "scripts": {
     "ctest": "cross-env BROWSER=chromium node --unhandled-rejections=strict test/test.js",

diff --git a/src/webkit/wkPage.ts b/src/webkit/wkPage.ts
@@ -559,6 +559,10 @@ export class WKPage implements PageDelegate {
         height: viewport.height,
       }),
     ];
+    if (options.isMobile) {
+      const angle = viewport.width > viewport.height ? 90 : 0;
+      promises.push(this._session.send('Page.setOrientationOverride', { angle }));
+    }
     await Promise.all(promises);
   }
 

diff --git a/test/emulation.spec.js b/test/emulation.spec.js
@@ -137,7 +137,16 @@ describe.skip(FFOX)('viewport.isMobile', () => {
     await context1.close();
     await context2.close();
   });
-  it.fail(WEBKIT)('should fire orientationchange event', async({browser, server}) => {
+  it('should support window.orientation emulation', async({browser, server}) => {
+    const context = await browser.newContext({ viewport: { width: 300, height: 400 }, isMobile: true });
+    const page = await context.newPage();
+    await page.goto(server.PREFIX + '/mobile.html');
+    expect(await page.evaluate(() => window.orientation)).toBe(0);
+    await page.setViewportSize({width: 400, height: 300});
+    expect(await page.evaluate(() => window.orientation)).toBe(90);
+    await context.close();
+  });
+  it('should fire orientationchange event', async({browser, server}) => {
     const context = await browser.newContext({ viewport: { width: 300, height: 400 }, isMobile: true });
     const page = await context.newPage();
     await page.goto(server.PREFIX + '/mobile.html');