Skip to content

Commit

Permalink
fix(webkit): fix non-mac screenshots w/ dsf
Browse files Browse the repository at this point in the history
  • Loading branch information
pavelfeldman committed Apr 4, 2020
1 parent e9428b6 commit d5f5fbe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"playwright": {
"chromium_revision": "754895",
"firefox_revision": "1069",
"webkit_revision": "1187"
"webkit_revision": "1188"
},
"scripts": {
"ctest": "cross-env BROWSER=chromium node test/test.js",
Expand Down
4 changes: 2 additions & 2 deletions test/screenshot.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ module.exports.describe = function({testRunner, expect, product, playwright, FFO
expect(screenshot).toBeInstanceOf(Buffer);
}
});
it.fail(WEBKIT)('should work with device scale factor', async({browser, server}) => {
it('should work with device scale factor', async({browser, server}) => {
const context = await browser.newContext({ viewport: { width: 320, height: 480 }, deviceScaleFactor: 2 });
const page = await context.newPage();
await page.goto(server.PREFIX + '/grid.html');
Expand Down Expand Up @@ -394,7 +394,7 @@ module.exports.describe = function({testRunner, expect, product, playwright, FFO
expect(screenshot).toBeGolden('screenshot-element-mobile.png');
await context.close();
});
it.fail(WEBKIT && LINUX).skip(FFOX)('should work with device scale factor', async({browser, server}) => {
it.skip(FFOX)('should work with device scale factor', async({browser, server}) => {
const context = await browser.newContext({ viewport: { width: 320, height: 480 }, deviceScaleFactor: 2 });
const page = await context.newPage();
await page.goto(server.PREFIX + '/grid.html');
Expand Down

0 comments on commit d5f5fbe

Please sign in to comment.