Skip to content

Commit

Permalink
feat: use WebKit stub on MacOS 10.14 (#6892)
Browse files Browse the repository at this point in the history
This will yield the following error when installing new playwright
and launching WebbKit on MacOS 10.14

```
node:internal/process/promises:246
          triggerUncaughtException(err, true /* fromPromise */);
          ^

browserType.launch: Protocol error (Playwright.enable): Browser closed.
==================== Browser output: ====================
<launching> /Users/aslushnikov/prog/playwright/browser_patches/deprecated-webkit-mac-10.14/pw_run.sh --inspector-pipe --headless --no-startup-window
<launched> pid=57578
[pid=57578][out] ERROR: this version of Playwright does not support running WebKit on MacOS 10.14. Please either update MacOS to 10.15+ or use Playwright@v1.11
[pid=57578] <process did exit: exitCode=1, signal=null>
[pid=57578] starting temporary directories cleanup
=========================== logs ===========================
<launching> /Users/aslushnikov/prog/playwright/browser_patches/deprecated-webkit-mac-10.14/pw_run.sh --inspector-pipe --headless --no-startup-window
<launched> pid=57578
[pid=57578][out] ERROR: this version of Playwright does not support running WebKit on MacOS 10.14. Please either update MacOS to 10.15+ or use Playwright@v1.11
[pid=57578] <process did exit: exitCode=1, signal=null>
[pid=57578] starting temporary directories cleanup
============================================================
```

References #6879
  • Loading branch information
aslushnikov authored Jun 4, 2021
1 parent 657aa04 commit cfcf6a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"revision": "1492",
"installByDefault": true,
"revisionOverrides": {
"mac10.14": "1444"
"mac10.14": "1445"
}
},
{
Expand Down

0 comments on commit cfcf6a8

Please sign in to comment.