Skip to content

Commit

Permalink
test: add a test for sourceURL in exception stacks (#1880)
Browse files Browse the repository at this point in the history
  • Loading branch information
dgozman committed Apr 20, 2020
1 parent 649f37f commit a000335
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions test/page.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -500,12 +500,18 @@ describe('Page.Events.PageError', function() {
expect(error.name).toBe('Error');
expect(error.message).toBe('Fancy error!');
let stack = await page.evaluate(() => window.e.stack);
// Note that WebKit does not use sourceURL for some reason and reports the stack of the 'throw' statement
// instead of the Error constructor call.
// Note that WebKit reports the stack of the 'throw' statement instead of the Error constructor call.
if (WEBKIT)
stack = stack.replace('14:25', '15:19');
expect(error.stack).toBe(stack);
});
it.fail(WEBKIT)('should contain sourceURL', async({page, server}) => {
const [error] = await Promise.all([
page.waitForEvent('pageerror'),
page.goto(server.PREFIX + '/error.html'),
]);
expect(error.stack).toContain('myscript.js');
});
});

describe('Page.setContent', function() {
Expand Down

0 comments on commit a000335

Please sign in to comment.