Conversation
Closed
Member
Author
|
Here's how the SVGs look: 
|
dgozman
approved these changes
Sep 1, 2025
| if (browserId) | ||
| await this._reusedBrowser.closeBrowser(browserId, 'User requested close from VS Code Extension'); | ||
| else | ||
| this._reusedBrowser.closeAllBrowsers(); |
Member
Author
There was a problem hiding this comment.
no, this just closes the underlying process and has also been synchronous before.
Skn0tt
added a commit
to Skn0tt/playwright-vscode
that referenced
this pull request
Oct 1, 2025
This reverts commit 6663081.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds UI for showing a list of browsers, each with a "Pick Locator" and "Close" button. This uses the data from microsoft/playwright#37027. On old versions, we try to infer the browser information from the currently selected project.
Screen.Recording.2025-08-14.at.15.51.47.mov