Skip to content

chore: refactor server, prepare for browser reuse #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

pavelfeldman
Copy link
Member

No description provided.

console.error(e);
});
// eslint-disable-next-line no-console
void connection.close().catch(e => console.error(e));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe await?

src/server.ts Outdated
setupExitWatchdog() {
const handleExit = async () => {
setTimeout(() => process.exit(0), 15000);
for (const connection of this._connectionList)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do Promise.all instead?

@pavelfeldman pavelfeldman merged commit 54ed7c3 into microsoft:main May 28, 2025
6 checks passed
sariwa15 pushed a commit to sariwa15/adjusted-playwright-mcp that referenced this pull request Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants