chore: roll driver to 1.46.0-beta #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Jul 31, 2024
| } | ||
| clientCertificates.add(jsonCert); | ||
| } | ||
| params.remove("clientCertificates"); |
There was a problem hiding this comment.
Not that I mind, but it's surprising there could already be a property with this name.
Member
Author
There was a problem hiding this comment.
That's because we use new Gson().toJSON(options), we can either nullify the option before the call or remove it from JSON like here.
playwright/src/test/java/com/microsoft/playwright/TestClientCertificates.java
Outdated
Show resolved
Hide resolved
mxschmitt
approved these changes
Jul 31, 2024
playwright/src/test/java/com/microsoft/playwright/TestGlobalFetch.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1598