chore: throw on context.close() if it was closed externally #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of microsoft/playwright@09ff7ea
mxschmitt
reviewed
Mar 27, 2023
playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java
Show resolved
Hide resolved
mxschmitt
reviewed
Mar 27, 2023
Contributor
mxschmitt
left a comment
mxschmitt
left a comment
There was a problem hiding this comment.
Looks different to the upstream impl. I'd if closeWasCalled and then early return to not have to wait for the closePromise.
dgozman
approved these changes
Mar 27, 2023
Member
Author
There is a bug in the upstream implementation, it should wait for close promise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of microsoft/playwright@09ff7ea