Support signing collections #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2022 13:23
Adds support for signing collections, similar to items, by signing its assets.
|
@TomAugspurger I can't think of another way around that issue - I would be worried though about other asset types that specifically shouldn't be signed. If we end up with another URL that we want to avoid signing, perhaps we can creating a settings-driven mechanism for a list of netloc that shouldn't be signed. For now though I think this works fine. |
lossyrob
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for signing collections, similar to items, by signing its assets.
This is useful for things like geoparquet-items on collections like https://planetarycomputer.microsoft.com/api/stac/v1/collections/sentinel-2-l2a, or zero-item collections like https://planetarycomputer.microsoft.com/api/stac/v1/collections/gridmet, which only have collection-level assets.
One issue (maybe blocker?) is that we would try to sign the
thumbnailasset inai4edatapublicassets. I've added a special case to skip that storage account: https://github.com/microsoft/planetary-computer-sdk-for-python/pull/41/files#diff-8db575884228ad7de2ce4dfdee5da40298e0dc951de875d31438feee8bc71950R134. @lossyrob are you OK with that special case?