Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deploying Windows container images. #40

Merged
merged 3 commits into from
May 6, 2021
Merged

Support deploying Windows container images. #40

merged 3 commits into from
May 6, 2021

Conversation

chunye
Copy link
Contributor

@chunye chunye commented Apr 23, 2021

No description provided.

jvano
jvano approved these changes Apr 25, 2021
View reviewed changes
Copy link

@jvano jvano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jvano
Copy link

jvano commented Apr 25, 2021

@AmrutaKawade can you help us merging this PR?

pagariyaalok
pagariyaalok approved these changes Apr 25, 2021
View reviewed changes
Copy link

@pagariyaalok pagariyaalok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

AmrutaKawade
AmrutaKawade reviewed Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@AmrutaKawade AmrutaKawade left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this validation

https://github.com/Azure/webapps-deploy/blob/a98be40ccf5d3017a21681529ff244f96d597fca/src/ActionInputValidator/Validations.ts#L114

since this method is used in publishprofile container validator. It will not get called for windows based apps because of this validation

@JasonFreeberg
Copy link

@DS-MS @AmrutaKawade -- Quick question, will the webapps-deploy action need an update to use the latest version of this library?

@AmrutaKawade
Copy link
Collaborator

@DS-MS @AmrutaKawade -- Quick question, will the webapps-deploy action need an update to use the latest version of this library?

yes

@chunye
Copy link
Contributor Author

chunye commented Apr 29, 2021

@BALAGA-GAYATRI, can you approve?

@JasonFreeberg
Copy link

Hi folks, can we merge this in now? (@BALAGA-GAYATRI , @AmrutaKawade)

@BALAGA-GAYATRI BALAGA-GAYATRI merged commit 007a208 into microsoft:master May 6, 2021
@chunye chunye mentioned this pull request May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pagariyaalok pagariyaalok pagariyaalok approved these changes

@AmrutaKawade AmrutaKawade AmrutaKawade approved these changes

@BALAGA-GAYATRI BALAGA-GAYATRI BALAGA-GAYATRI approved these changes

@thesattiraju thesattiraju thesattiraju approved these changes

@jvano jvano jvano approved these changes

@kaverma kaverma Awaiting requested review from kaverma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chunye @jvano @JasonFreeberg @AmrutaKawade @pagariyaalok @thesattiraju @BALAGA-GAYATRI