Skip to content

Fixing Stream.__repr__ to match CPython#84

Merged
pamelafox merged 3 commits into
microsoft:mainfrom
pamelafox:stream-repr
Sep 23, 2022
Merged

Fixing Stream.__repr__ to match CPython#84
pamelafox merged 3 commits into
microsoft:mainfrom
pamelafox:stream-repr

Conversation

@pamelafox

Copy link
Copy Markdown
Member

Fixes the format and allows "name" attribute to be a number.

@codecov-commenter

codecov-commenter commented Sep 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #84 (ebf0963) into main (bd95a84) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   88.88%   88.91%   +0.02%     
==========================================
  Files          11       11              
  Lines        2061     2065       +4     
==========================================
+ Hits         1832     1836       +4     
  Misses        229      229              
Impacted Files Coverage Δ
src/picologging/streamhandler.cxx 94.80% <100.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybaloney tonybaloney left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👍🏻

@tonybaloney

Copy link
Copy Markdown
Collaborator

Formatter needs running before it can be merged

@pamelafox
pamelafox merged commit 9585bc5 into microsoft:main Sep 23, 2022
@pamelafox
pamelafox deleted the stream-repr branch September 23, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants