Skip to content

Fix dictconfig resetting child loggers#70

Merged
tonybaloney merged 1 commit into
microsoft:mainfrom
aminalaee:fix-dictconfig-handler-child-loggers
Sep 13, 2022
Merged

Fix dictconfig resetting child loggers#70
tonybaloney merged 1 commit into
microsoft:mainfrom
aminalaee:fix-dictconfig-handler-child-loggers

Conversation

@aminalaee

Copy link
Copy Markdown
Contributor

Fixes #67 .

The code was using the CPython version with PlaceHolder, it didn't have test coverage. This adds the tests and fixes the issue.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #70 (8e0f3e5) into main (16f49d3) will increase coverage by 0.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   85.55%   86.01%   +0.46%     
==========================================
  Files          11       11              
  Lines        2125     2124       -1     
==========================================
+ Hits         1818     1827       +9     
+ Misses        307      297      -10     
Impacted Files Coverage Δ
src/picologging/__init__.py 92.69% <ø> (ø)
src/picologging/config.py 82.38% <100.00%> (+4.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybaloney

Copy link
Copy Markdown
Collaborator

Thanks @aminalaee I'll raise another issue to improve the coverage of the config submodule as well

@tonybaloney
tonybaloney self-requested a review September 13, 2022 02:35
@tonybaloney
tonybaloney merged commit 813dc98 into microsoft:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: module 'picologging' has no attribute 'PlaceHolder'

3 participants