Skip to content

Add formatException method in Formatter#68

Merged
tonybaloney merged 3 commits into
microsoft:mainfrom
aminalaee:add-formatter-format-exception
Sep 13, 2022
Merged

Add formatException method in Formatter#68
tonybaloney merged 3 commits into
microsoft:mainfrom
aminalaee:add-formatter-format-exception

Conversation

@aminalaee

@aminalaee aminalaee commented Sep 10, 2022

Copy link
Copy Markdown
Contributor

Adds formatException method in Formatter according to the standard library.

@codecov-commenter

codecov-commenter commented Sep 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #68 (7685a51) into main (16f49d3) will decrease coverage by 0.24%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   85.55%   85.30%   -0.25%     
==========================================
  Files          11       11              
  Lines        2125     2157      +32     
==========================================
+ Hits         1818     1840      +22     
- Misses        307      317      +10     
Impacted Files Coverage Δ
src/picologging/formatter.cxx 85.39% <68.75%> (-3.65%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aminalaee aminalaee changed the title Add Formatter formatException Add formatException method in Formatter Sep 10, 2022
@tonybaloney

Copy link
Copy Markdown
Collaborator

Great stuff.
👍🏻 I'll run this through memray to check for leaks before merging

@tonybaloney

Copy link
Copy Markdown
Collaborator

No leaks detected

@tonybaloney
tonybaloney merged commit eb4c277 into microsoft:main Sep 13, 2022
@aminalaee
aminalaee deleted the add-formatter-format-exception branch September 13, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants