Add dictConfig#61
Merged
Merged
Conversation
Collaborator
|
please rebase |
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 86.31% 85.45% -0.86%
==========================================
Files 10 11 +1
Lines 1900 2111 +211
==========================================
+ Hits 1640 1804 +164
- Misses 260 307 +47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aminalaee
marked this pull request as ready for review
August 20, 2022 17:47
tonybaloney
reviewed
Aug 22, 2022
aminalaee
force-pushed
the
add-dictconfig
branch
from
August 23, 2022 08:00
dacc2d3 to
d886079
Compare
Collaborator
|
Thanks I'll ship this after reviewing the others |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53
Please review #63 before this.