Fix Logger setLevel not resetting other levels#57
Merged
tonybaloney merged 2 commits intoAug 9, 2022
Conversation
aminalaee
force-pushed
the
fix-setlevel-reset-other-levels
branch
from
August 5, 2022 13:58
d5775ea to
f0811c4
Compare
tonybaloney
reviewed
Aug 8, 2022
tonybaloney
reviewed
Aug 8, 2022
aminalaee
force-pushed
the
fix-setlevel-reset-other-levels
branch
from
August 8, 2022 08:45
b2ee1d1 to
f144044
Compare
aminalaee
force-pushed
the
fix-setlevel-reset-other-levels
branch
from
August 8, 2022 08:46
f144044 to
af2afa0
Compare
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 86.28% 86.39% +0.10%
==========================================
Files 10 10
Lines 1881 1896 +15
==========================================
+ Hits 1623 1638 +15
Misses 258 258
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aminalaee
force-pushed
the
fix-setlevel-reset-other-levels
branch
from
August 8, 2022 08:50
af2afa0 to
480aa10
Compare
…evel-reset-other-levels
aminalaee
force-pushed
the
fix-setlevel-reset-other-levels
branch
from
August 8, 2022 08:51
480aa10 to
0220afa
Compare
tonybaloney
approved these changes
Aug 9, 2022
Collaborator
|
thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
At first I thought it should only reset lower levels, which is a bit less verbose, but it should also reset higher levels:
for example: