Skip to content

Add SocketHandler#48

Merged
tonybaloney merged 5 commits into
microsoft:mainfrom
aminalaee:add-socket-handler
Aug 5, 2022
Merged

Add SocketHandler#48
tonybaloney merged 5 commits into
microsoft:mainfrom
aminalaee:add-socket-handler

Conversation

@aminalaee

@aminalaee aminalaee commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

From CPython here.

  • The tests would be cleaner if they were using classes but we would lose pytest features like repeat and fixtures
  • I specifically didn't add the benchmarks as they would need extra work for the server. Maybe we can add them in a separate PR.

@codecov-commenter

codecov-commenter commented Jul 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #48 (7a00567) into main (81fa4e6) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   85.65%   86.28%   +0.62%     
==========================================
  Files          10       10              
  Lines        1799     1881      +82     
==========================================
+ Hits         1541     1623      +82     
  Misses        258      258              
Impacted Files Coverage Δ
src/picologging/handlers.py 93.82% <100.00%> (+1.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aminalaee
aminalaee force-pushed the add-socket-handler branch from 43203df to 733af91 Compare July 22, 2022 12:09
@aminalaee
aminalaee marked this pull request as ready for review July 22, 2022 12:15
@aminalaee
aminalaee force-pushed the add-socket-handler branch from 733af91 to 622802d Compare July 22, 2022 12:51
Comment thread src/picologging/__init__.py Outdated
@tonybaloney
tonybaloney merged commit 40a629f into microsoft:main Aug 5, 2022
@aminalaee
aminalaee deleted the add-socket-handler branch August 5, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants