Add support for %f (format microseconds) to datefmt

[tarasko]

Closes #184

Since libc strftime doesn't support %f specifier the implementation works it around by

1. first, creating a temporary format string for strftime where %f is replaced with actual microseconds.
2. passing this temporary format string to strftime

The first step is optional, it will be only invoked if %f is detected by the Formatter constructor

import picologging as logging

logging.basicConfig(format="%(levelname)s - %(asctime)s - %(name)s - %(module)s - %(message)s", datefmt="%F %T.%f")
logger = logging.getLogger()
logger.setLevel(logging.INFO)

if __name__ == '__main__':
    for i in range(5):
        logger.info("Hello world! %d", i)

INFO - 2024-07-23 04:15:56.170199 - root - <unknown> - Hello world! 0
INFO - 2024-07-23 04:15:56.170242 - root - <unknown> - Hello world! 1
INFO - 2024-07-23 04:15:56.170255 - root - <unknown> - Hello world! 2
INFO - 2024-07-23 04:15:56.170265 - root - <unknown> - Hello world! 3
INFO - 2024-07-23 04:15:56.170274 - root - <unknown> - Hello world! 4

[tarasko]

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

[tarasko]

Hi @tonybaloney. Would you be able to take a look at my PRs please?
Do you think you will a make new release any time soon?

[tonybaloney]

The other PR is merged so I think this one can be closed?

[tarasko]

The other PR is merged so I think this one can be closed?

Sorry for confusion.

The other PR was just fixing default asctime formatting.
This one adds support for %f specifier.

I see some merge conflicts, I'll resolve them and add tests.
For now I'm converting this PR to draft. I'll restore it as soon as it's ready

[tarasko]

@tonybaloney
It is ready

[tonybaloney]

@tonybaloney

It is ready

Ah I understand now. I was looking at 3.13 support as well in another PR since it seems that the API for getting times changed and the old function for getting microseconds has been removed. So I'll consider that in this PR

[tarasko]

@tonybaloney
It is ready

Ah I understand now. I was looking at 3.13 support as well in another PR since it seems that the API for getting times changed and the old function for getting microseconds has been removed. So I'll consider that in this PR

Well this PR doesn't touch PyTime, but it seems like we just need to call PyTime_Time instead of _PyTime_GetSystemClockWithInfo for python 3.13.
Something like this:

#if PY_VERSION_HEX < 0x03130000
#define py_time _PyTime_t
int py_time_get_time(py_time* t) { return _PyTime_GetSystemClockWithInfo(&t, NULL); } 
#else
#define py_time PyTime_t
int py_time_get_time(py_time* t) { return PyTime_Time(&t); }
#endif

[tonybaloney]

@tonybaloney

It is ready

Ah I understand now. I was looking at 3.13 support as well in another PR since it seems that the API for getting times changed and the old function for getting microseconds has been removed. So I'll consider that in this PR

Well this PR doesn't touch PyTime, but it seems like we just need to call PyTime_Time instead of _PyTime_GetSystemClockWithInfo for python 3.13.

Something like this:

#if PY_VERSION_HEX < 0x03130000

#define py_time _PyTime_t

int py_time_get_time(py_time* t) { return _PyTime_GetSystemClockWithInfo(&t, NULL); } 

#else

#define py_time PyTime_t

int py_time_get_time(py_time* t) { return PyTime_Time(&t); }

#endif

Yes that's in #212

the API that's missing is the one to fetch milliseconds.

I've set it to zero until I can find a solution

[tarasko]

@tonybaloney

It is ready

Ah I understand now. I was looking at 3.13 support as well in another PR since it seems that the API for getting times changed and the old function for getting microseconds has been removed. So I'll consider that in this PR

Well this PR doesn't touch PyTime, but it seems like we just need to call PyTime_Time instead of _PyTime_GetSystemClockWithInfo for python 3.13.
Something like this:

#if PY_VERSION_HEX < 0x03130000

#define py_time _PyTime_t

int py_time_get_time(py_time* t) { return _PyTime_GetSystemClockWithInfo(&t, NULL); } 

#else

#define py_time PyTime_t

int py_time_get_time(py_time* t) { return PyTime_Time(&t); }

#endif

Yes that's in #212

the API that's missing is the one to fetch milliseconds.

I've set it to zero until I can find a solution

Ah I see.
I think PyTime_t is just nanoseconds. Perhaps this will just work:

long msec = std::ceil(static_cast<double>(t % 1000000000) / 1000000);

[Revolution1]

any update?

[DenchPokepon]

Looking forward to using your library with this feature :)