WIP: Update Handler handleError #177
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminalaee
commented
Sep 29, 2023
| PyObject* modDict = PyModule_GetDict(mod); // borrowed reference | ||
| PyObject* raiseExceptions = PyDict_GetItemString(modDict, "raiseExceptions"); // PyDict_GetItemString returns a borrowed reference | ||
| if (PyBool_Check(raiseExceptions) && PyErr_Occurred()) { | ||
| PyErr_Print(); |
There was a problem hiding this comment.
Need to format the exception probably the same way the Formatter does, with all frames.
aminalaee
commented
Sep 29, 2023
| record = picologging.LogRecord( | ||
| "test", picologging.INFO, __file__, 1, "test", (), None, None, None | ||
| ) | ||
| with pytest.raises(AttributeError): |
There was a problem hiding this comment.
This doesn't raise any errors with standard logging module. And also was not fixed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.