Skip to content

Add FileHandler errors argument#161

Merged
tonybaloney merged 1 commit into
microsoft:mainfrom
aminalaee:add-filehandler-errors-argument
Sep 26, 2023
Merged

Add FileHandler errors argument#161
tonybaloney merged 1 commit into
microsoft:mainfrom
aminalaee:add-filehandler-errors-argument

Conversation

@aminalaee
aminalaee force-pushed the add-filehandler-errors-argument branch from 8f61a92 to dd21c18 Compare September 25, 2023 08:52
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #161 (dd21c18) into main (a2842b9) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   88.86%   88.49%   -0.37%     
==========================================
  Files          11       11              
  Lines        2146     2147       +1     
==========================================
- Hits         1907     1900       -7     
- Misses        239      247       +8     
Files Coverage Δ
src/picologging/__init__.py 91.59% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@tonybaloney

Copy link
Copy Markdown
Collaborator

thanks @aminalaee

@tonybaloney
tonybaloney merged commit 9fcfbdf into microsoft:main Sep 26, 2023
@aminalaee
aminalaee deleted the add-filehandler-errors-argument branch September 26, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileHandler doesnt handle errors argument

3 participants