WIP: Add shutdown method #136
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminalaee
commented
Nov 16, 2022
| handlers = [logger.handlers for logger in root.manager.loggerDict.values()] + [ | ||
| root.handlers | ||
| ] | ||
| handlerList = list(itertools.chain(*handlers)) |
There was a problem hiding this comment.
There is probably a smarter way to get the list of handlers to flush/close. Any suggestions?
The standard logging uses a Weakref instance to hold refs but I guess that's not possible between C and Python types?
aminalaee
force-pushed
the
add-shutdown-method
branch
from
a28bc6d to
9ff7dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99
Adds the
shutdownmethod.WIP: The coverage tests will be added.