Skip to content

Fix leaks identified memray#115

Merged
tonybaloney merged 7 commits into
microsoft:mainfrom
tonybaloney:fix_formatter_leak
Oct 12, 2022
Merged

Fix leaks identified memray#115
tonybaloney merged 7 commits into
microsoft:mainfrom
tonybaloney:fix_formatter_leak

Conversation

@tonybaloney

@tonybaloney tonybaloney commented Oct 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Branch of #113 (merge that first)

Fixed leaks -

  • .filters collection in Filterer type
  • .style instance attribute in Formatter type
  • ._const_line_break in Formatter type
  • .name in Logger type
  • .fallback_handler in Logger type

@tonybaloney
tonybaloney requested a review from pamelafox October 12, 2022 04:55
pamelafox
pamelafox reviewed Oct 12, 2022
View reviewed changes
Comment thread src/picologging/logger.cxx
Comment thread src/picologging/formatter.cxx
Comment thread tests/memray/Makefile
@tonybaloney

tonybaloney commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator Author

@pamelafox updated please review

@tonybaloney
tonybaloney merged commit de33c22 into microsoft:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pamelafox pamelafox pamelafox approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonybaloney @pamelafox