Remove QueueListener test#101
Conversation
|
This is no way to test this - either adjust the test to make it pass, if you think it's faulty, or identify the issue. I know for a fact this is not working because I tested it on my end, see the link. But even if that was not the case, simply removing the test without a clear assertion there is no issue (via working test), is imho wrong. |
|
Well there was already a test for this that’s why I suggested to remove it. But if it’s different or I made a mistake we van close this. |
|
@aminalaee --> #102 |
that test only shows that the value is written to the stream. Yet the tests I added demonstrate that this is not written into the output captured by pytest. Something is not right - somewhere. |
|
I don't think the tests you updated are the same. I might be wrong though, let's wait for the maintainers to review. |
I simply used the example in the docs for the tests. In starlite I do not use the same code, and it still fails. |
|
[Posting on both relevant PRs] |
|
This is fine to remove now since the test based on it is now checked in: |
I think there's no issue with the QueueListener hut as explained it's a testing limitation with pytest caplog.
closes #90