snp: inject event when ext_int is valid
#1347
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cexisting implementation does `debug_assert!` which is not precise. The legacy HCL injects events when `ext_int` is valid, doesn't assert. `ext_int` doesn't have to be always valid when VMSA is busy. Do event injection when ext_int is valid, don't do otherwise. Additional value: * use `open_enum` in the existing defs, * add the constant for NMI, * replace magic numbers with constants
jstarks
reviewed
May 12, 2025
| @@ -415,6 +415,7 @@ open_enum! { | |||
| pub enum Exception: u8 { | |||
| DIVIDE_ERROR = 0x0, | |||
| DEBUG = 0x1, | |||
| NMI = 0x2, | |||
There was a problem hiding this comment.
Let's be careful here. Although NMIs use vector 2, they are not exceptions. I would leave this out.
There was a problem hiding this comment.
Ohh, I see that now! Thanks!!
jstarks
reviewed
May 12, 2025
| #[bitfield(u64)] | ||
| #[derive(IntoBytes, Immutable, KnownLayout, FromBytes, PartialEq, Eq)] | ||
| pub struct SevEventInjectInfo { | ||
| pub vector: u8, | ||
| #[bits(8)] | ||
| pub vector: Exception, |
There was a problem hiding this comment.
I'd leave this as u8 since this can be used to inject non-exceptions.
There was a problem hiding this comment.
Agreed 100%! I'll work on this more after completing more of the main quest :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation does
debug_assert!which is not precise. The legacy HCL injects events whenext_intis valid, doesn't assert.ext_intdoesn't have to be always valid when VMSA is busy.Do event injection when
ext_intis valid, don't do otherwise.Additional value:
open_enumin the existing defs,